New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
monitoring: add namespace to ceph node down query #8793
Merged
leseb
merged 1 commit into
rook:master
from
aruniiird:add-namespace-to-ceph-node-down-query
Sep 27, 2021
Merged
monitoring: add namespace to ceph node down query #8793
leseb
merged 1 commit into
rook:master
from
aruniiird:add-namespace-to-ceph-node-down-query
Sep 27, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leseb
changed the title
Add namespace to ceph node down query
monitoring: add namespace to ceph node down query
Sep 23, 2021
leseb
approved these changes
Sep 23, 2021
aruniiird
force-pushed
the
add-namespace-to-ceph-node-down-query
branch
from
September 23, 2021 19:49
660534c
to
502d4ee
Compare
@Mergifyio rebase (to try to get CI to pass) |
BlaineEXE
approved these changes
Sep 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciate the very clear messages for users about how to resolve the issue. 👍
Command
|
leseb
force-pushed
the
add-namespace-to-ceph-node-down-query
branch
from
September 24, 2021 17:40
502d4ee
to
1fde2f0
Compare
@Mergifyio rebase |
This will add 'namespace' field into the result of 'ceph_node_down' query. Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
Command
|
leseb
force-pushed
the
add-namespace-to-ceph-node-down-query
branch
from
September 27, 2021 08:37
1fde2f0
to
11ff00e
Compare
leseb
added a commit
that referenced
this pull request
Sep 27, 2021
monitoring: add namespace to ceph node down query (backport #8793)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is on top of PR #8774
Description of your changes:
Which issue is resolved by this Pull Request:
Resolves #
Checklist:
make codegen
) has been run to update object specifications, if necessary.